RFR: 8252324: Signal related code should be shared among POSIX platforms [v4]

[Martin Doerr]

On Mon, 28 Sep 2020 04:37:03 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert "Add AIX specific SA code"
>>   
>>   This reverts commit cc13700d7d3f15927e22d92d9f5ec9a0739ef9a1.
>
> Hi Gerard,
> Thank you for tackling this long overdue cleanup and conciliation of the the signal management code! Great work on a
> tedious task.
> Overall this looks okay but I confess it is very hard to compare each previous platform version with the new shared
> version. I'm glad the AIX folk have take an indepth look there.
> I have a few minor comments in specific files below.
> 
> I would also suggest naming the file posixSignal.cpp/hpp as that is the more common naming pattern.
> 
> Future cleanup: do we really need JVM_handle_<os>_signal to be cpu specific? I can imagine one copy of this with a few
> ifdefs or newly introduced os::pd_* functions.
> Thanks,
> David

Tests on AIX look good so far. Maybe we should re-check after conflict resolution, but basically, I think it can get
pushed when reviews are done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/157