RFR: 8264482: container info misleads on non-container environment

Yasumasa Suenaga ysuenaga at openjdk.java.net
Thu Apr 1 13:03:52 UTC 2021


On Wed, 31 Mar 2021 14:05:37 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> I'm a bit nervous about the container_runtime addition. Can this be done in a separate bug, please? What testing has been done? Has this been tested with docker and podman? Did you run tests in `test/hotspot/jtreg/containers` ?
>
> Thanks @jerboaa and @dholmes-ora for the comment!
> I haven't aware JDK-8261242, so I will remove the code to set container runtime name.
> 
> The reason why I sent this PR is I found "container_type" in hs_err log even though I did not run JVM on the container. It was confising. I agree to check cgroups configuration, but we should not use "container" for them. cgroups is not only for containers.
> 
>> Did you run tests in test/hotspot/jtreg/containers ?
> 
> I haven't run them yet. I attempted to fix `OSContainer::is_containerized()` as JDK-8261242 said, but I do not have environment to run test/hotspot/jtreg/containers test. So I fixed UL output only, and confirmed it does not affect their tests.

I removed container runtime detection code - this PR changes log / hs_err / VM.info message only at result.
How about this? please review it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3280


More information about the hotspot-runtime-dev mailing list