RFR: 8264123: add ThreadsList.is_valid() support

Robbin Ehn rehn at openjdk.java.net
Thu Apr 1 17:37:25 UTC 2021


On Thu, 1 Apr 2021 09:23:48 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> ThreadsLists need an is_valid() function and checks in various
>> places to help catch bugs where a ThreadsList is dangling.
>> 
>> Other minor changes:
>> - change raw `_threads_hazard_ptr` access to used `get_threads_hazard_ptr()`.
>> - `get_threads_hazard_ptr()` should be `const`.
>> - fix a couple of old typos.
>> 
>> Update: forgot to mention that this fix was tested with Mach5 Tier[1-8].
>
> Hi Dan,
> 
> I have seen some other verification code which also might be performance impacting, can we got over and measure what the cost is for different verification when you gotten your bake time here? So we can take an informed decision based on what the cost vs debuggability in product is.
> 
> Looks good, thanks.

> @robehn - Thanks for the review!
> 
> Are you saying that I should measure the cost of these `guarantee()` calls before
> I switch them to `assert()` calls in the future? If that's what you mean, I'll include
> a note for that when I file the new bug. If that's not what you mean, please let me
> know what you do mean.

Yes

-------------

PR: https://git.openjdk.java.net/jdk/pull/3255


More information about the hotspot-runtime-dev mailing list