RFR: 8264412: AArch64: CPU description should refer DMI [v2]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Tue Apr 6 01:25:24 UTC 2021
On Mon, 5 Apr 2021 18:14:44 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refactoring
>
> 2 small nitpicks, but otherwise the functionality of the code looks good to me, though I will have to trust you on using the files to get the CPU description, since I'm no Linux expert:
>
> "/proc/device-tree/compatible",
> "/sys/devices/virtual/dmi/id/board_name",
> "/sys/devices/virtual/dmi/id/product_name"
Thanks @gerard-ziemski for the comment!
I used `os::open()`, `os::read()`, and `os::close()` in new commit.
And also I moved `buf[read_sz - 1]` to just before `return true`.
> 2 small nitpicks, but otherwise the functionality of the code looks good to me, though I will have to trust you on using the files to get the CPU description, since I'm no Linux expert:
>
> ```
> "/proc/device-tree/compatible",
> "/sys/devices/virtual/dmi/id/board_name",
> "/sys/devices/virtual/dmi/id/product_name"
> ```
They are suggested in https://github.com/openjdk/jdk/pull/2759#issuecomment-789391247
-------------
PR: https://git.openjdk.java.net/jdk/pull/3259
More information about the hotspot-runtime-dev
mailing list