RFR: 8257831: Suspend with handshakes [v2]

Serguei Spitsyn sspitsyn at openjdk.java.net
Tue Apr 6 19:00:43 UTC 2021


On Tue, 6 Apr 2021 11:09:52 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi Robbin,
>> 
>> This is a great piece of work with a lot of code simplifications. Unfortunately some new complexities that need to be hidden by appropriate abstractions. Lots of comments, queries and suggestions below.
>> 
>> Thanks,
>> David
>
>> Hi Robbin,
>> 
>> This is a great piece of work with a lot of code simplifications. Unfortunately some new complexities that need to be hidden by appropriate abstractions. Lots of comments, queries and suggestions below.
>> 
>> Thanks,
>> David
> 
> Thanks David!

Hi Robbin,
I'm looking at it. I have a concern that it can significantly impact Loom implementation. There is a non-trivial update in Loom to support virtual threads in JVMTI Suspend/Resume. So we need to make sure your approach is going to work for virtual threads as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191


More information about the hotspot-runtime-dev mailing list