RFR: 8257831: Suspend with handshakes [v3]

Robbin Ehn rehn at openjdk.java.net
Wed Apr 7 13:12:18 UTC 2021


On Wed, 31 Mar 2021 06:27:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' into SuspendInHandshake
>>  - Merge branch 'master' into SuspendInHandshake
>>  - 8257831: Suspend with handshake (review baseline)
>
> src/hotspot/share/runtime/sweeper.cpp line 276:
> 
>> 274: 
>> 275:     ThreadBlockInVM tbivm(thread);
>> 276:     thread->java_suspend_self();
> 
> AFAICS the only change needed in this function was to delete the java_suspend_self as it is not handled in the TBIVM.

Fixed

> src/hotspot/share/runtime/thread.cpp line 460:
> 
>> 458:   delete metadata_handles();
>> 459: 
>> 460:   // SR_handler uses this as a termination indicator -
> 
> As noted previously we need a replacement for this as a proxy for a Thread (not JavaThread) terminating.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191


More information about the hotspot-runtime-dev mailing list