RFR: 8264412: AArch64: CPU description should refer DMI [v4]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Thu Apr 8 02:03:15 UTC 2021


On Wed, 7 Apr 2021 17:02:55 GMT, Andrew Haley <aph at openjdk.org> wrote:

>>> Maybe we should just concatenate all three files?
>> 
>> Do you mean we should concatenate "compatible", "board_name", and "product_name"? It's impossible. We can see "compatible" file on the device which uses device tree, however we cannot see both "board_name" and "product_name" on it. Thus I prefer to attempt to read them sequentially.
>
>> > Maybe we should just concatenate all three files?
>> 
>> Do you mean we should concatenate "compatible", "board_name", and "product_name"? It's impossible.
> 
> Of course it isn't impossible. But if you really want to skip a file which is just "\n", then please check for the file being just "\n", not a file with "\n" as its first character.

I pushed new commit to check the contents whether it is just "\n". Could you review again?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3259


More information about the hotspot-runtime-dev mailing list