RFR: 8257831: Suspend with handshakes [v4]

Robbin Ehn rehn at openjdk.java.net
Mon Apr 12 07:47:07 UTC 2021


On Fri, 9 Apr 2021 15:34:50 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - White space fixes
>>  - Merge branch 'master' into SuspendInHandshake
>>  - Review fixes
>>  - Merge branch 'master' into SuspendInHandshake
>>  - Merge branch 'master' into SuspendInHandshake
>>  - 8257831: Suspend with handshake (review baseline)
>
> src/hotspot/share/runtime/handshake.hpp line 131:
> 
>> 129:       return true;
>> 130:     }
>> 131:     OrderAccess::loadload();
> 
> Needs a comment explaining what the memory sync is for.

Fixed

> src/hotspot/share/runtime/handshake.hpp line 156:
> 
>> 154:   // This flag is true while there is async handshake (trap)
>> 155:   // on queue. Since we do only need one, we can reuse it if
>> 156:   // thread thread gets suspended again (after a resume)
> 
> typo: s/thread thread/thread/

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191


More information about the hotspot-runtime-dev mailing list