RFR: 8257831: Suspend with handshakes [v7]

Robbin Ehn rehn at openjdk.java.net
Wed Apr 14 06:42:18 UTC 2021


On Tue, 13 Apr 2021 16:49:53 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Obsolete unused flags
>>  - Review fixes 3
>
> src/hotspot/share/runtime/arguments.cpp line 525:
> 
>> 523:   { "FlightRecorder",               JDK_Version::jdk(13), JDK_Version::undefined(), JDK_Version::undefined() },
>> 524:   { "SuspendRetryCount",            JDK_Version::jdk(16), JDK_Version::jdk(17), JDK_Version::jdk(18) },
>> 525:   { "SuspendRetryDelay",            JDK_Version::jdk(16), JDK_Version::jdk(17), JDK_Version::jdk(18) },
> 
> I think both 'jdk(16)' values here need to be 'jdk(17)' since
> we didn't deprecate these option in JDK16. Or they might
> need to be 'JDK_Version::undefined()' since we didn't
> deprecate these options before obsoleting them.
> @dholmes-ora will know for sure.

Fixed with undefined() as David said.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191


More information about the hotspot-runtime-dev mailing list