RFR: 8264412: AArch64: CPU description should refer DMI [v4]

Andrew Haley aph at redhat.com
Wed Apr 14 09:28:32 UTC 2021


On 4/14/21 12:40 AM, Yasumasa Suenaga wrote:
> 
> @theRealAph The latest change uses `strncmp(buf, "\n", 2)` to check whether the content just has "\n". Are you ok this change?

No, that's obviously wrong. "\n" is only one character, so it makes no sense
to use strncmp(). Please check for a file containing just "\n", which is

  (read_sz == 1 && *buf == '\n')

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the hotspot-runtime-dev mailing list