RFR: 8264412: AArch64: CPU description should refer DMI [v5]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Wed Apr 14 12:09:14 UTC 2021
On Tue, 30 Mar 2021 16:20:40 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update conditions
>
> This patch is basically OK, except the question about a somewhat obscure bit of code.
> > @theRealAph The latest change uses `strncmp(buf, "\n", 2)` to check whether the content just has "\n". Are you ok this change?
>
> No, that's obviously wrong. "\n" is only one character, so it makes no sense
> to use strncmp(). Please check for a file containing just "\n", which is
>
> (read_sz == 1 && *buf == '\n')
I pushed new commit. @theRealAph Could you review again?
-------------
PR: https://git.openjdk.java.net/jdk/pull/3259
More information about the hotspot-runtime-dev
mailing list