RFR: JDK-8261238: NMT should not limit baselining by size threshold [v5]

Thomas Stuefe stuefe at openjdk.java.net
Wed Apr 21 11:50:40 UTC 2021


On Wed, 21 Apr 2021 10:09:35 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge
>>  - Split out display changes
>>  - Exclude zero-sized regions from baseline
>>  - Start
>
> I'm convinced that Thomas' version is better. Especially after his additional enhancement he has promised (JDK-8261491).
> NMT should be able to dectect memory leaks caused by small allocations. So using no threshold should be default IMHO. And I prefer not to add a switch.

Thanks @TheRealMDoerr  and @zhengyu123 !

I'll wait until tomorrow. If nobody objects, I will merge this change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2428


More information about the hotspot-runtime-dev mailing list