RFR: 8265757: stack-use-after-scope in perfMemory_posix.cpp get_user_name_slow()
David Holmes
dholmes at openjdk.java.net
Thu Apr 22 23:35:29 UTC 2021
On Thu, 22 Apr 2021 15:09:25 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
> Please review this small change to fix JDK-8265757. The fix was tested with Mach5 tiers 1 and 2 on Linux, MacOS aarch64, and Windows.
>
> Thanks, Harold
Changes requested by dholmes (Reviewer).
src/hotspot/os/posix/perfMemory_posix.cpp line 530:
> 528: char* oldest_user = NULL;
> 529: time_t oldest_ctime = 0;
> 530: char buffer[MAXPATHLEN + 1];
If you move this inside the #if defined(LINUX) it would be better. No risk of perturbing other platforms then.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3630
More information about the hotspot-runtime-dev
mailing list