RFR: 8264760: JVM crashes when two threads encounter the same resolution error [v3]

Wang Huang whuang at openjdk.java.net
Fri Apr 23 02:49:24 UTC 2021


On Mon, 12 Apr 2021 23:50:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add throw exception
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1939:
> 
>> 1937:     ResolutionErrorEntry* entry = resolution_errors()->find_entry(index, hash, pool, which);
>> 1938:     if (entry != NULL && entry->nest_host_error() == NULL) {
>> 1939:       entry->set_nest_host_error(message);
> 
> Please add a comment before line 1939:
> // An existing entry means we had a true resolution failure (LinkageError) with our nest host, but we
> // still want to add the error message for the higher-level access checks to report. We should
> // only reach here under the same error condition, so we can ignore the potential race with setting
> // the message. If we see it is already set then we can ignore it.

OK. Thank you for your advice. I will add that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3392


More information about the hotspot-runtime-dev mailing list