RFR: 8265831: 8257831 broke Windows x86 build

Aleksey Shipilev shade at openjdk.java.net
Fri Apr 23 07:46:24 UTC 2021


On Fri, 23 Apr 2021 07:26:52 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Hi,
> 
> may I please have reviews for this trivial build fix? Thanks!
> 
> The error is just a missing include. I have no idea why this only breaks x86 though. It has nothing to do with different calling conventions between caller and callee (typical for x86 windows). I just assume the Windows x64 build pulls semaphore.inline.hpp via some other includes.
> 
> Cheers, Thomas

Looks good and trivial. I also see this failure in my Windows nightlies, and also only on x86_32.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3647


More information about the hotspot-runtime-dev mailing list