RFR: 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Tue Apr 27 22:01:18 UTC 2021
On Tue, 27 Apr 2021 21:30:26 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> We currently have array_klass() and array_klass_or_null(), where the former can throw exceptions and the latter can not. But they both delegate to:
>>
>> array_klass_impl(bool or_null, TRAPS)
>>
>> which combines both the exception-throwing and non-exception-throwing code into one method declared with TRAPS. To make progress with the change of TRAPS to JavaThread (JDK-8252685) we need to separate these code paths into distinct methods.
>>
>> Testing: tiers 1-3 (in progress)
>>
>> Thanks,
>> David
>
> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>
> - Merge
> - Feedback from Ioi and Coleen: make the base API pure virtual and override those methods
> directly, getting rid of the impl versions,
> - 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API
Looks great.
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3711
More information about the hotspot-runtime-dev
mailing list