RFR: 8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN [v2]
Calvin Cheung
ccheung at openjdk.java.net
Tue Aug 3 22:59:57 UTC 2021
On Tue, 3 Aug 2021 22:01:40 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>>
>> @tstuefe comments
>
> src/hotspot/share/runtime/os.cpp line 992:
>
>> 990: st->print("%s", env_list[i]);
>> 991: st->print("=");
>> 992: st->print("%s", envvar);
>
> I suggest adding a comment like:
> // Use separate cr() printing to avoid unnecessary buffer operations that might cause truncation
Thanks for taking another look.
I've added the comment.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4947
More information about the hotspot-runtime-dev
mailing list