RFR: 8263567: gtests don't terminate the VM safely

Thomas Stuefe stuefe at openjdk.java.net
Wed Aug 4 07:22:31 UTC 2021


On Wed, 4 Aug 2021 07:01:47 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Please review this fix to shutdown cleanly any JVMs created by gtests that aren't aborted.
>> 
>> Testing:
>>   - manual instrumentation to check all JVM construction and then deletion during gtest runs
>>   - local gtest testing
>>   - tiers 1-3 gtest testing
>> 
>> Thanks,
>> David
>
> test/hotspot/gtest/gtestMain.cpp line 113:
> 
>> 111:   char** _argv;
>> 112:   bool _is_initialized;
>> 113:   JavaVM* jvm;
> 
> underscore missing?

and `_is_initialized` is now redundant and could be aliased to `_jvm != NULL`

-------------

PR: https://git.openjdk.java.net/jdk/pull/4986


More information about the hotspot-runtime-dev mailing list