RFR: 8272345: macos doesn't check `os::set_boot_path()` result [v2]

Igor Ignatyev iignatyev at openjdk.java.net
Thu Aug 12 03:38:51 UTC 2021


> Hi all,
> 
> could you please review this small fix?
> 
> from JBS:
>> we don't check `os::set_boot_path()` return value on macos, which leads to a crash/assert down the road in case we weren't able to set BCP. on all other OSes, we terminate JVM w/ "Failed setting boot class path." error message.
> 
> testing:
> - [x] tier1
> - [x] `runtime/cds/appcds/MoveJDKTest.java`
> 
> 
> Thanks,
> -- Igor

Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:

  enable the test on all platforms but windows

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5094/files
  - new: https://git.openjdk.java.net/jdk/pull/5094/files/1d8d2947..74a8168b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5094&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5094&range=00-01

  Stats: 5 lines in 1 file changed: 1 ins; 3 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5094.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5094/head:pull/5094

PR: https://git.openjdk.java.net/jdk/pull/5094


More information about the hotspot-runtime-dev mailing list