RFR: 8272305: several hotspot runtime/modules don't check exit codes [v2]

David Holmes dholmes at openjdk.java.net
Mon Aug 16 01:03:27 UTC 2021


On Fri, 13 Aug 2021 17:01:50 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this patch that adds exit code checks to five `runtime/modules` tests?
>> 
>> testing: `runtime/modules` on `{linux,windows,macos}-x64`
>> 
>> Thanks,
>> -- Igor
>
> Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   renamed positive to shouldVMFail
>   reordered test cases

Looks good.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5078


More information about the hotspot-runtime-dev mailing list