[jdk17] RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34 [v2]

David Holmes dholmes at openjdk.java.net
Mon Aug 16 01:43:46 UTC 2021


On Mon, 16 Aug 2021 01:17:40 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback - minor updates
>
> test/hotspot/jtreg/runtime/StackGuardPages/exeinvoke.c line 75:
> 
>> 73: void set_signal_handler() {
>> 74:   if (altstack == NULL) {
>> 75:     // Dynamically allocated incase SIGSTKSZ is not constant
> 
> "incase" --> "in case"?
> Also need to update the copyright year.

Both fixed. Thanks for the review @DamonFool !

-------------

PR: https://git.openjdk.java.net/jdk17/pull/304


More information about the hotspot-runtime-dev mailing list