RFR: 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag

David Holmes dholmes at openjdk.java.net
Tue Aug 24 07:23:31 UTC 2021

On Mon, 23 Aug 2021 22:51:34 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> could you please review the patch which replaces the flag used by `DoubleFlagWithIntegerValue` to `SweeperThreshold`? 
> from JBS:
>> `runtime/CommandLine/DoubleFlagWithIntegerValue.java` test uses `G1ConcMarkStepDurationMillis` flag which is available only on the builds w/ G1 GC, hence this test might fail on the builds where G1 is disabled. 
>> instead of adding `@requires` to exclude the test from running on builds w/o G1, the test can be updated to use the flag that is available in all builds.
> testing: `runtime/CommandLine/DoubleFlagWithIntegerValue.java`  on `{linux,windows,macosx}-x64`
> Thanks,
> -- Igor




Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5233

More information about the hotspot-runtime-dev mailing list