RFR: 8262188: Add test to verify trace page sizes logging on Linux [v3]

Stefan Johansson sjohanss at openjdk.java.net
Mon Mar 1 11:14:04 UTC 2021


> Please review this new test that checks the output from `-Xlog:pagesize` and compares it to what's really used according to `/proc/self/smaps`.
> 
> We already have a few tests that check the output from `-Xlog:pagesize`, the difference is that those tests expect some page size given the parameters used. This new test instead check if the values printed out are correct with regards to what is recorded in `/proc/self/maps`.
> 
> I wrote the test to see if all our logging was correct, and found those two issues that are now fixed:
> [JDK-8261029: Code heap page sizes not traced correctly using os::trace_page_sizes](https://bugs.openjdk.java.net/browse/JDK-8261029)
> [JDK-8261230: GC tracing of page sizes are wrong in a few places](https://bugs.openjdk.java.net/browse/JDK-8261230)
> 
> The test now passes and it will be a good way to prevent incorrect page size logging to be added going forward.
> 
> **Testing**
> The new test has been run through mach5 without any problems and also manually on configurations with explicit large pages enabled.

Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:

  8262188: Schatzl review

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2696/files
  - new: https://git.openjdk.java.net/jdk/pull/2696/files/d869aed2..c45bbcbc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2696&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2696&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2696.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2696/head:pull/2696

PR: https://git.openjdk.java.net/jdk/pull/2696


More information about the hotspot-runtime-dev mailing list