RFR: 8262368: wrong verifier message for bogus return type [v2]

Harold Seigel hseigel at openjdk.java.net
Mon Mar 1 16:11:55 UTC 2021


On Mon, 1 Mar 2021 02:32:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changed error message text
>
> src/hotspot/share/classfile/verifier.cpp line 3152:
> 
>> 3150:     verify_error(ErrorContext::bad_type(bci,
>> 3151:         current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
>> 3152:         "Method descriptor has a void return type");
> 
> I would prefer "Method does not expect a return value".

I changed the messages to what you suggested.
Thanks for reviewing this change.
Harold

-------------

PR: https://git.openjdk.java.net/jdk/pull/2757


More information about the hotspot-runtime-dev mailing list