RFR: 8262910: Cleanup THREAD/TRAPS/naming and typing issues in ObjectMonitor and related code [v3]

Daniel D.Daugherty dcubed at openjdk.java.net
Thu Mar 4 23:46:53 UTC 2021


On Wed, 3 Mar 2021 16:25:37 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More pointer declaration style fixups
>
> src/hotspot/share/runtime/synchronizer.hpp line 146:
> 
>> 144: 
>> 145:   // Deflate idle monitors:
>> 146:   static void chk_for_block_req(JavaThread* current, const char* op_name,
> 
> I like "current" better than "self" as a convention.

Out of all the changes from "self" -> "current"... how did you decide to land
a comment on this one... :-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/2802


More information about the hotspot-runtime-dev mailing list