RFR: 8263191: Consolidate ThreadInVMfromJavaNoAsyncException and ThreadBlockInVMWithDeadlockCheck with existing wrappers

Coleen Phillimore coleenp at openjdk.java.net
Tue Mar 9 01:41:12 UTC 2021


On Mon, 8 Mar 2021 19:33:06 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Hi,
> 
> Please review the following small patch. ThreadInVMfromJavaNoAsyncException is exactly the same as ThreadInVMfromJava except that in the destructor we avoid checking for asynchronous exceptions. Similarly ThreadBlockInVMWithDeadlockCheck is equal to ThreadBlockInVM except that in the destructor we might need to release a Mutex in case we need to stop for a safepoint or handshake.
> We can consolidate these two wrappers with the existing ones to avoid code duplication and minimize the number of transition wrappers.
> 
> Tested in mach5 tiers 1-3.
> 
> Thanks,
> Patricio

Looks good!

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2880


More information about the hotspot-runtime-dev mailing list