RFR: 8262454: Handshake timeout improvements, single target, kill unfinished thread [v3]

[Robbin Ehn]

On Tue, 9 Mar 2021 14:59:23 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Spelling error
>
> src/hotspot/share/runtime/handshake.cpp line 204:
> 
>> 202:     log_error(handshake)("No thread with an unfinished handshake op(" INTPTR_FORMAT ") found.", p2i(op));
>> 203:   }
>> 204:   fatal("Handshake timeout");
> 
> The old code did a log_stream.flush() before calling fatal().
> Did you decide that wasn't necessary anymore?
> 
> Update: Or maybe the old code needed it because it was doing log_stream.print()
> calls and the new code is calling log_err(handshake) which doesn't need it... Dunno...

It's not needed.

> src/hotspot/share/runtime/handshake.cpp line 189:
> 
>> 187:       if (thr->handshake_state()->operation_pending(op)) {
>> 188:         log_error(handshake)("JavaThread " INTPTR_FORMAT " has not cleared handshake op: " INTPTR_FORMAT, p2i(thr), p2i(op));
>> 189:         target = thr;
> 
> Perhaps add a comment above this line:
>   // Remember the last one found for more diagnostics below.

Fixed

> test/hotspot/jtreg/runtime/handshake/HandshakeTimeoutTest.java line 27:
> 
>> 25: import jdk.test.lib.Utils;
>> 26: import jdk.test.lib.process.ProcessTools;
>> 27: import jdk.test.lib.process.OutputAnalyzer;
> 
> Should these be in alpha sort order?

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/2743