RFR: 8262454: Handshake timeout improvements, single target, kill unfinished thread [v4]

[Daniel D.Daugherty]

On Thu, 11 Mar 2021 08:13:30 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> When executing a single target handshake we do not have a timeout.
>> When we timeout we should crash the thread with the non-completed handshake operation.
>> 
>> VM_Handshake only had one implementer so I remove it.
>> 
>> Passes t1-5.
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Merge branch 'master' into 8262454-hs-timeout-st
>  - Added comment, sorted imports in test
>  - Spelling error
>  - Fixed cr year
>  - Merge branch 'master' into 8262454-hs-timeout-st
>  - Use WB waitUnsafe to trigger timeout
>  - Merge branch 'master' into 8262454-hs-timeout-st
>  - Fixed timeout

Thumbs up. Minor nit about the sort order of the imports in the new test remains.

test/hotspot/jtreg/runtime/handshake/HandshakeTimeoutTest.java line 26:

> 24: 
> 25: import jdk.test.lib.process.ProcessTools;
> 26: import jdk.test.lib.process.OutputAnalyzer;

These two are still out of alpha-sort order...

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2743