RFR: 8263191: Consolidate ThreadInVMfromJavaNoAsyncException and ThreadBlockInVMWithDeadlockCheck with existing wrappers [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Thu Mar 11 20:56:09 UTC 2021


On Tue, 9 Mar 2021 20:32:18 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Hi,
>> 
>> Please review the following small patch. ThreadInVMfromJavaNoAsyncException is exactly the same as ThreadInVMfromJava except that in the destructor we avoid checking for asynchronous exceptions. Similarly ThreadBlockInVMWithDeadlockCheck is equal to ThreadBlockInVM except that in the destructor we might need to release a Mutex in case we need to stop for a safepoint or handshake.
>> We can consolidate these two wrappers with the existing ones to avoid code duplication and minimize the number of transition wrappers.
>> 
>> Tested in mach5 tiers 1-3.
>> 
>> Thanks,
>> Patricio
>
> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add asserts for thread state + check_asyncs name

Thanks for making the fixes you've done so far, but I still
have one nagging question...

-------------

Changes requested by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2880


More information about the hotspot-runtime-dev mailing list