RFR: 8263470: Consolidate copies of getClassBytes in various tests

Coleen Phillimore coleenp at openjdk.java.net
Fri Mar 12 17:47:10 UTC 2021


On Fri, 12 Mar 2021 15:14:19 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> See issue for details. This also moves ClassUnloadCommon and ClassWithManyMethodsClassLoader to jdk/lib/test/classloader and puts it in a package with other class loader test utility functions. I left getClassBytes in ClassunloadCommon, because most tests that use it also need to import ClassUnloadCommon.
>> 
>> Tested with tier1-3.
>
> Hi Coleen,
> 
> LGTM. We loose the "filename is" debug output, was that intentional?
> 
> Cheers, Thomas

Thanks Harold and Thomas.  Removing the "filename is" debug output wasn't purely intentional, but I'd like to leave it out since it appears that this code works now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2954


More information about the hotspot-runtime-dev mailing list