RFR: JDK-8263559: Add missing initializers to VM_PopulateDumpSharedSpace [v2]

David Holmes david.holmes at oracle.com
Mon Mar 15 12:00:28 UTC 2021


On 15/03/2021 5:24 pm, Thomas Stuefe wrote:
> On Sun, 14 Mar 2021 23:17:27 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> 
>>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    Remove explicit NULL resets
>>
>> Oops,  agree with Kim. The later assignments to NULL should be removed.
> 
> Kim, Ioi, thanks. I removed the explicit NULL assignments.
> 
> Side note, I know VM_op::do_it() is supposed to run only once, and in straight succession from constructing the object, but I wonder if it would make sense to assert this.

?? Assert what exactly. A VMOperation can have all kinds of behaviour. 
Obviously you have to create it, then you submit via execute and 
eventually the VMThread will call do_it(). But one VM_op could be used 
multiple times.

David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/2996
> 


More information about the hotspot-runtime-dev mailing list