RFR: 8263556: remove `@modules java.base` from tests

Daniel D.Daugherty dcubed at openjdk.java.net
Mon Mar 15 13:33:09 UTC 2021


On Sat, 13 Mar 2021 20:26:42 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review this trivial cleanup?
> from JBS:
> 
>> jtreg `@modules X` directive does two things: 
>>  - exclude a test from execution if JDK under test doesn't have module X 
>>  - if JDK under test has module X, make sure it's resolved 
>> 
>> both these things have no sense for `java.base` module as it's always available and is always resolved.
> 
> 
> Thanks,
> -- Igor

Thumbs up.

I agree that this is a trivial change.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2990


More information about the hotspot-runtime-dev mailing list