RFR: 8261479: CDS runtime code should check exceptions
Yumin Qi
minqi at openjdk.java.net
Fri Mar 19 23:32:39 UTC 2021
On Fri, 19 Mar 2021 21:13:29 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
> Proposed changes include:
>
> - For the functions which could throw exceptions, the callers should pass in CHECK instead of THREAD.
>
> - For the functions which won't throw exceptions, put THREAD as the first parameter.
> E.g.`static bool add_unregistered_class(Thread* current, InstanceKlass* k);`
>
> - For the functions which won't throw exceptions and don't use THREAD, just simply get rid of the TRAPS parameter.
>
> Testing: passed tiers 1 and 2, in-progress tiers 3 and 4.
LGTM.
src/hotspot/share/classfile/classLoaderExt.hpp line 111:
> 109:
> 110: static void record_result(const s2 classpath_index,
> 111: InstanceKlass* result);
110/111 can merge into one line.
-------------
Marked as reviewed by minqi (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3097
More information about the hotspot-runtime-dev
mailing list