RFR: 8263915: runtime/cds/appcds/MismatchedPathTriggerMemoryRelease.java fails when UseCompressedClassPointers is off [v2]

Yumin Qi minqi at openjdk.java.net
Tue Mar 23 00:08:39 UTC 2021


On Mon, 22 Mar 2021 23:39:00 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> runtime/cds/appcds/MismatchedPathTriggerMemoryRelease.java fails on x86_32 due to failure of this check [1].
>> However, this check will always fail if UseCompressedClassPointers=0 [2] (e.g., on x86_32) since the class_space_rs remains unreserved.
>> It would be better to fix it.
>> 
>> Thanks.
>> Best regards,
>> Jie
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/runtime/cds/appcds/MismatchedPathTriggerMemoryRelease.java#L66
>> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/memory/metaspaceShared.cpp#L1141
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Relax the regexp

LGTM.

-------------

Marked as reviewed by minqi (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3110


More information about the hotspot-runtime-dev mailing list