RFR: 8261551: Remove special CDS handling in Metaspace::allocate [v2]

Ioi Lam iklam at openjdk.java.net
Thu Mar 25 17:12:47 UTC 2021


On Thu, 25 Mar 2021 06:43:03 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Hi Ioi,
> 
> This seems fine. But I noticed that preload_and_dump doesn't let exceptions escape so should not itself be a TRAPS method (and it can be called with main_thread rather than THREAD).
> 
> Thanks,
> David

Thanks for noticing. I removed `TRAPS` from `MetaspaceShared::preload_and_dump()` in the updated version, since it's somewhat related to this issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3185


More information about the hotspot-runtime-dev mailing list