RFR: 8264142: Remove TRAPS/THREAD parameters for verifier related functions

Coleen Phillimore coleenp at openjdk.java.net
Thu Mar 25 19:19:26 UTC 2021


On Thu, 25 Mar 2021 18:00:02 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> src/hotspot/share/classfile/classFileParser.cpp line 5636:
>> 
>>> 5634: // its _class_name field.
>>> 5635: void ClassFileParser::prepend_host_package_name(const InstanceKlass* unsafe_anonymous_host) {
>>> 5636:   JavaThread* current = JavaThread::current();
>> 
>> Can you pass Thread* current as the first parameter instead?  We're trying to minimize materializing the current thread.
>
> How about if "ResourceMark rm(THREAD)" is changed to "ResourceMark rm;" ?  Then no Thread* is need in the function.

This seems fine to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3194


More information about the hotspot-runtime-dev mailing list