RFR: 8264429: Test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build

Yi Yang yyang at openjdk.java.net
Tue Mar 30 14:44:06 UTC 2021


On Tue, 30 Mar 2021 14:19:23 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> The test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build since it checks for `out.shouldContain("OpenJDK")`. Relax this restriction now.
>> 
>> Thanks~
>> Yang
>
> Thumbs up.
> 
> This is a trivial fix and does not need to wait for 24 hours.

Thanks @dcubed-ojdk @shipilev for the reviews, since it's a trivial fix, I think it can be integrated right now.

For @shipilev : Yes, it fails as expected when the original fix was reverted(See detailed [VerifyWithDefaultArchive.jtr.log](https://github.com/openjdk/jdk/files/6229798/VerifyWithDefaultArchive.jtr.log) attachment in this PR).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3268


More information about the hotspot-runtime-dev mailing list