RFR: 8244540: Print more information with -XX:+PrintSharedArchiveAndExit [v2]

[Calvin Cheung]

On Tue, 30 Mar 2021 03:40:33 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Hi, Please review
>>   Added more info in printout when -XX:+PrintSharedArchiveAndExit used:
>>   archive names (static/dynamic or static only)
>>   loaded classes and their loaders
>>   number of shared symbols
>>   number of shared strings
>>   full vm version stored in shared archive.
>>   added two tests for custom loader test and dynamic test.
>> 
>>   Tests: tier1,tier2,tier3,tier4
>> 
>> Thanks
>> Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed class output with no reset index. Separated output from dynamic from static. Removed verbose loaded_by from output.

Looks good. Just a small nit on the test cases.

Thanks,
Calvin

test/hotspot/jtreg/runtime/cds/appcds/customLoader/PrintSharedArchiveAndExit.java line 85:

> 83:               .shouldContain("Shared Unregistered Dictionary")
> 84:               .shouldMatch("Number of shared symbols: \\d+")
> 85:               .shouldMatch("Number of shared strings: \\d+");

Since the print output includes "VM version", perhaps the above should look for it?

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/PrintSharedArchiveAndExit.java line 93:

> 91:                       .shouldContain("CustomLoadee unregistered_loader")
> 92:                       .shouldContain("Shared Builtin Dictionary")
> 93:                       .shouldContain("Shared Unregistered Dictionary")

Since the print output includes "VM version", perhaps the above should look for it?

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3187