RFR: 8264413: Data is written to file header even if its CRC32 was calculated [v4]

[Yi Yang]

> Many tests under `runtime/cds/appcds/dynamicArchive` are crashed when turning on VerifySharedSpaces, VM reports inconsistent crc32 between dumptime and runtime(See detailed content on JBS attachments):
> 
> $ diff dump.log run.log
> 17c17
> < - base_archive_is_default:        0
> ---
>> - base_archive_is_default:        1
> 19c19
> < - base_archive_name_size:         0
> ---
>> - base_archive_name_size:         113
> 
> The root cause is that even if the CRC32 is calculated(Line 1902), ArchiveBuilder is still writing data to FileMapInfo(Line 1903):
> 
> https://github.com/openjdk/jdk/blob/4ea6abfbd1818fa7049bc4f6e46d568e842acb34/src/hotspot/share/memory/archiveBuilder.cpp#L1091-L1094
> 
> https://github.com/openjdk/jdk/blob/4ea6abfbd1818fa7049bc4f6e46d568e842acb34/src/hotspot/share/memory/filemap.cpp#L1236-L1251
> 
> Now the expected CRC32(serialized in CDS archive) is different from the calculated ones at runtime. This patch addresses this problem, it writes base_archive_name and size into header **before** calculating CRC32(if needed).
> 
> Thanks~
> Yang

Yi Yang has updated the pull request incrementally with one additional commit since the last revision:

  add new jtreg test with VerifySharedSpaces

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3261/files
  - new: https://git.openjdk.java.net/jdk/pull/3261/files/4502220d..c4b27fdc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3261&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3261&range=02-03

  Stats: 72 lines in 1 file changed: 72 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3261.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3261/head:pull/3261

PR: https://git.openjdk.java.net/jdk/pull/3261