RFR: 8257831: Suspend with handshakes [v2]

Robbin Ehn rehn at openjdk.java.net
Wed Mar 31 11:02:18 UTC 2021


On Tue, 30 Mar 2021 21:12:47 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> Hi Robbin,
> 
> this is a great simplification. Excellent work! :)
> 
> Thanks, Richard.

Thanks Richard!

> src/hotspot/share/prims/jvmtiRawMonitor.cpp line 421:
> 
>> 419:     guarantee(jt->thread_state() == _thread_in_native, "invariant");
>> 420:     for (;;) {
>> 421:       if (!SafepointMechanism::should_process(jt)) {
> 
> Potential follow-up enhancement: there's a very similar for(;;) loop in JvmtiRawMonitor::raw_enter(). It looks as if it was possible to merge both loops into just one loop in simple_enter().

Yes!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191


More information about the hotspot-runtime-dev mailing list