Integrated: 8265465: jcmd VM.cds should keep already dumped archive when exception happens

Yumin Qi minqi at openjdk.java.net
Fri May 7 03:04:57 UTC 2021


On Wed, 5 May 2021 16:10:21 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> Hi, Please review 
>   When using jcmd to dump shared archive, if the archive name exists,  it will be deleted first. If exception happens during dumping process, there is no new archive created. This PR changes to first dump the archive with  a temporary file name. With successful dump, the temporary file will be rename to its given name. This way the old archive will not be touched on exception.
>   The newly added test case skipped testing on Windows since File operation result is not same as on Linux.
>   
>    Tests: tier1,tier2,tier3,tier4
> 
> Thanks
> Yumin

This pull request has now been integrated.

Changeset: 43ad24fe
Author:    Yumin Qi <minqi at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/43ad24feb20ed2007922472a15873e1094147b0d
Stats:     169 lines in 4 files changed: 132 ins; 4 del; 33 mod

8265465: jcmd VM.cds should keep already dumped archive when exception happens

Reviewed-by: iklam, ccheung

-------------

PR: https://git.openjdk.java.net/jdk/pull/3886


More information about the hotspot-runtime-dev mailing list