RFR: JDK-8266503: [UL] Make Decorations safely copy-able and reduce their size [v4]

Thomas Stuefe stuefe at openjdk.java.net
Fri May 7 10:21:11 UTC 2021


On Thu, 6 May 2021 09:40:42 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
>> 
>>  - Merge
>>  - Xins debug check proposal
>>  - LogTagSet::describe_tagsets can use the stream interface of label and avoid copying
>>  - Merge
>>  - Remove harfbuzz build fix
>>  - Volker feedback
>>  - start
>>  - cherry-picked JDK-8266536
>>  - harfbuzz-buildfix
>
> Hi Thomas,
> 
> your change looks good and I like it :)
> 
> Am I right that you've changed the 256-char-for-all-decorators limit to a 255-char limit for a single decorator (which is obviously much better)?
> 
> Find my other comments inline.
> 
> Thank you and best regards,
> Volker

@simonis : if you approve, I will push.

All nightlies at SAP ran through fine.

..thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/3874


More information about the hotspot-runtime-dev mailing list