RFR: 8266742: Check W^X state on possible safepoint [v2]

[David Holmes]

On Thu, 13 May 2021 16:18:19 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Hi,
>> 
>> Please review a check for W^X mode at safepoint. As described in the bug, this explicit check aims to catch the wrong W^X mode that may lead to a crash (such crashes are rather intermittent).
>> 
>> This check helped to verify the fix for https://bugs.openjdk.java.net/browse/JDK-8265292 and should help to discover similar issues. It is disabled by default to avoid unexpected failures in the regular use, but eventually it should be turned on unconditionally.
>> 
>> I still owe a complete W^X approach description. Hope this patch does not depend much on that.
>
> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change option and method name

Changes looks good to me.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3920