RFR: 8266851: Implement JEP 403: Strongly Encapsulate JDK Internals [v3]

Mark Reinhold mr at openjdk.java.net
Tue May 18 23:01:07 UTC 2021


On Fri, 14 May 2021 08:54:23 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Mark Reinhold has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove now-unnecessary uses and mentions of the --illegal-access option
>
> test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java line 26:
> 
>> 24: /**
>> 25:  * @test
>> 26:  * @requires vm.compMode != "Xcomp"
> 
> I think `@requires vm.compMode != "Xcomp" was added because the test took too long with -Xcomp. I think it can be dropped now.

Dropped.

> test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java line 37:
> 
>> 35: 
>> 36: /**
>> 37:  * Basic test of --illegal-access=value to deny or permit access to JDK internals.
> 
> The comment should probably be updated as the test no longer tests denying or permitting access.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4015


More information about the hotspot-runtime-dev mailing list