RFR: 8267347: CDS record_linking_constraint asserts with unregistered class

[Yumin Qi]

On Fri, 21 May 2021 17:58:25 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> In CDS terms, "Unregistered classes" are the archived classes that should be loaded by custom class loaders during runtime. Archiving of class loader constraints ([JDK-8178349](https://bugs.openjdk.java.net/browse/JDK-8178349)) should be disabled for such classes.
> 
> During CDS dump time (-Xshare:dump), unregistered classes are loaded by the boot loader (see also [JDK-8261941](https://bugs.openjdk.java.net/browse/JDK-8261941)). `SystemDictionaryShared::record_linking_constraint` doesn't properly recognize such classes, leading to the assert.

LGTM.

test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java line 104:

> 102:             String testCase = Integer.toString(i);
> 103:             String cmdLine[] = new String[] {
> 104:                "--add-modules",

Here is not aligned with below.

-------------

Marked as reviewed by minqi (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4147