RFR: 8266963: Remove safepoint poll introduced in 8262443 due to reentrance issue [v2]

David Holmes david.holmes at oracle.com
Mon May 24 12:37:29 UTC 2021


On 24/05/2021 7:54 pm, Robbin Ehn wrote:
> On Mon, 24 May 2021 09:27:15 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>> Hold on a moment! This undoes 8262443, so what happens with the issue that bug was fixing?
> 
> As I said above, it's seem like I'm the only one seen an issue with this, so I'm the finder/reporter and fixer of the original bug.
> In a ZGC branch they run this code in StackWater, which than also hits this problem.
> Since this is just a performance enhancement it was suggested to just remove this.
> 
> I don't have time to figure out exactly what happens when we start looping here, so I'm fine with removing this for now.

In that case 8262443 needs to be updated to explain this.

Thanks,
David

> Thanks, Robbin
> 
>>
>> David
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/4028
> 


More information about the hotspot-runtime-dev mailing list