RFR: 8267095: Miscellaneous cleanups in vm.runtime.defmeth tests [v2]

Thu May 27 12:46:08 UTC 2021

On Thu, 27 May 2021 12:30:29 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/StressTest.java line 163:
>> 
>>> 161:             majorVerValues[i] = MIN_MAJOR_VER + i;
>>> 162:         }
>>> 163: 
>> 
>> Does this mean that the stress tests will run for all class versions between JDK 1.5 and JDK 17 ?  If so, maybe change it to just run for JDK 1.5, 11, and 17 releases?
>
> It means that the stress test will randomly pick test cases with class file versions between `MIN_MAJOR_VER` and `MAX_MAJOR_VER`. IMO it's a decent compromise between testing only  `MIN_MAJOR_VER` and `MAX_MAJOR_VER` (all other defmeth tests are configured that way) and always enumerating all the class file versions in every test (`MIN_MAJOR_VER ... MAX_MAJOR_VER`). So, I'd prefer to keep it as is.

That sounds good.  Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4008