RFR: 8241423: NUMA APIs fail to work in dockers due to dependent syscalls are disabled by default [v2]

Jie Fu jiefu at openjdk.java.net
Fri May 28 13:55:11 UTC 2021


On Thu, 27 May 2021 07:08:28 GMT, Per Liden <pliden at openjdk.org> wrote:

>>> But then we should remove the check in ZGC, since it serves no purpose anymore when the same check is done in `libnuma_init`.
>> 
>> Yes, this is a more general solution.
>> 
>> I used to send the RFR in 2020 [1].
>> But the community didn't pay much attention to it at that time.
>> So we have to get #3704 fixed because ZGC always crashed in docker with numa, while others wouldn't.
>> 
>> This week, @tschatzl encouraged me to try JDK-8241423 again.
>> So I sent this PR yesterday hoping that it can be fixed for other gcs too.
>> 
>> Changes in ZGC (JDK-8241354 and JDK-8266217) would become unnecessary if this PR is accepted.
>> And to make it to be more friendly to get reviewed, it would be better to file another RFE to remove them in ZGC.
>> Thanks.
>> 
>> [1] https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-March/041149.html
>
>> Changes in ZGC (JDK-8241354 and JDK-8266217) would become unnecessary if this PR is accepted.
>> And to make it to be more friendly to get reviewed, it would be better to file another RFE to remove them in ZGC.
> 
> I just think the backout of JDK-8241354 and JDK-8266217 should have have been part of this PR. Otherwise this gets harder to review, since the question why we do redundant checks now pops up. But sure, if you prefer backing out JDK-8241354 and JDK-8266217 as a separate change, I'm fine with that too.

Thanks @pliden .

-------------

PR: https://git.openjdk.java.net/jdk/pull/4205


More information about the hotspot-runtime-dev mailing list