RFR: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info [v2]

Calvin Cheung ccheung at openjdk.java.net
Mon Oct 25 04:24:02 UTC 2021


On Mon, 25 Oct 2021 00:32:23 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove empty CleanupDumpTimeLambdaProxyClassTable ctor
>
> src/hotspot/share/cds/metaspaceShared.cpp line 515:
> 
>> 513:   HeapShared::run_full_gc_in_vm_thread();
>> 514: 
>> 515:   SystemDictionaryShared::start_dumping();
> 
> What is the significance of this? It seems unrelated to the bug being fixed.

It is for setting the `_dump_in_progress` flag to true so that no new entries will be added to the `_dumptime_table`.
The `SystemDictionaryShared::start_dumping()` is being called for the dynamic dumping case, it would be consistent
if it is also called for the static dumping case.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6070


More information about the hotspot-runtime-dev mailing list