RFR: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info [v2]

Calvin Cheung ccheung at openjdk.java.net
Mon Oct 25 20:58:08 UTC 2021


On Mon, 25 Oct 2021 05:49:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> It is for setting the `_dump_in_progress` flag to true so that no new entries will be added to the `_dumptime_table`.
>> The `SystemDictionaryShared::start_dumping()` is being called for the dynamic dumping case, it would be consistent
>> if it is also called for the static dumping case.
>
> Perhaps but again that seems a different issue unrelated to this bug. Nor is it immediately obvious that the dynamic dumping and static dumping are equivalent in this regard. If the flag was only added for the dynamic case then apparently the static case does not need it - no?

I've reverted the change of calling `SystemDictionaryShared::start_dumping()` for the static dump case.
If the call is needed, it will be addressed via a separate bug.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6070


More information about the hotspot-runtime-dev mailing list